Fix issue: #254 - Fix for negative duration times.#302
Open
tsocha wants to merge 8 commits intofacebookresearch:mainfrom
Open
Fix issue: #254 - Fix for negative duration times.#302tsocha wants to merge 8 commits intofacebookresearch:mainfrom
tsocha wants to merge 8 commits intofacebookresearch:mainfrom
Conversation
Due to rounding timestamps, there were cases where the duration became negative for very small intervals. This commit fixes that by ensuring that any negative durations are set to zero after rounding. It also enables the Frequent CUDA Kernel Patterns analysis which failed so far. Signed-off-by: Benedykt Bela <benedykt.bela@intel.com>
Signed-off-by: Benedykt Bela <benedykt.bela@intel.com>
meta-cla
bot
added
the
CLA Signed
Author
|
@briancoutinho @hjli-creator could you look at this PR? |
Signed-off-by: Benedykt Bela <benedykt.bela@intel.com>
Signed-off-by: Benedykt Bela <benedykt.bela@intel.com>
Initial approach was to set all negative values to 0.0. The more precise approach is to round to zero both positive and negative values that are smaller than a defined accuracy which is currently set to 1e-9. Signed-off-by: Benedykt Bela <benedykt.bela@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #254.
This PR replaces all negative values with 0.
Before submitting