Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Image features in polyencoder #2412

Merged
merged 115 commits into from
Mar 11, 2020
Merged

Image features in polyencoder #2412

merged 115 commits into from
Mar 11, 2020

Commits on Feb 12, 2020

  1. Start to pass through image features

    @EricMichaelSmith
    EricMichaelSmith committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    86b0ea3 View commit details
    Browse the repository at this point in the history

  2. Work on image features in polyencoder

    @EricMichaelSmith
    EricMichaelSmith committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    109733c View commit details
    Browse the repository at this point in the history

  3. Work on revamping

    @EricMichaelSmith
    EricMichaelSmith committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    e4929bf View commit details
    Browse the repository at this point in the history

  4. Simplify image encoding

    @EricMichaelSmith
    EricMichaelSmith committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    744f4ca View commit details
    Browse the repository at this point in the history

  5. Tweax

    @EricMichaelSmith
    EricMichaelSmith committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    5584ac9 View commit details
    Browse the repository at this point in the history

  6. Prepend mode

    @EricMichaelSmith
    EricMichaelSmith committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    bf36218 View commit details
    Browse the repository at this point in the history

  7. Add mode

    @EricMichaelSmith
    EricMichaelSmith committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    fb9f38e View commit details
    Browse the repository at this point in the history

  8. Flag fix

    Eric Smith committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    744a33a View commit details
    Browse the repository at this point in the history

  9. Minor fixes

    Eric Smith committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    85cc617 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Setup for merged encoder

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    0043ea4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'polyencoder-with-image' of github.com:facebookresearch/… 

    …ParlAI into polyencoder-with-image
    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    f3430d1 View commit details
    Browse the repository at this point in the history

  3. Getting new encoder to match old

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    3990ebc View commit details
    Browse the repository at this point in the history

  4. Remove unneeded things

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    ba9188d View commit details
    Browse the repository at this point in the history

  5. Revert a bit

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    09a8b4c View commit details
    Browse the repository at this point in the history

  6. Multiple trivial reduction types

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    92b73c9 View commit details
    Browse the repository at this point in the history

  7. Fix pos

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    1dd717d View commit details
    Browse the repository at this point in the history

  8. Add postpend mode

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    e88c411 View commit details
    Browse the repository at this point in the history

  9. Change param name back

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    bf32454 View commit details
    Browse the repository at this point in the history

  10. Rip out old code

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    c49b7cb View commit details
    Browse the repository at this point in the history

  11. New cat()

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    8627c72 View commit details
    Browse the repository at this point in the history

  12. Smart add

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    29d390a View commit details
    Browse the repository at this point in the history

  13. Fix forward()

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    e7f4108 View commit details
    Browse the repository at this point in the history

  14. Comment

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    1896dd3 View commit details
    Browse the repository at this point in the history

  15. Minor

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    54af92f View commit details
    Browse the repository at this point in the history

  16. Minor

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    5990018 View commit details
    Browse the repository at this point in the history

  17. Finally, merge in new ContextWithImage module

    @EricMichaelSmith
    EricMichaelSmith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    8d4fdfc View commit details
    Browse the repository at this point in the history

  18. Import bugs

    Eric Smith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    172ec95 View commit details
    Browse the repository at this point in the history

  19. Fixes

    Eric Smith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    431104d View commit details
    Browse the repository at this point in the history

  20. Breakpoint

    Eric Smith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    225f90d View commit details
    Browse the repository at this point in the history

  21. Minor, but maybe will help test to pass

    Eric Smith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    3ae3b08 View commit details
    Browse the repository at this point in the history

  22. Remove breakpoint

    Eric Smith committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    e7f1283 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2020

  1. Dealing with new params

    Eric Smith committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    fd5fd8d View commit details
    Browse the repository at this point in the history

  2. DataParallel fix

    Eric Smith committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    dad3b36 View commit details
    Browse the repository at this point in the history

  3. Register untrained params as buffers

    Eric Smith committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    1cc2a01 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2020

  1. Add persona+WoW teachers

    Eric Smith committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    b17cc0f View commit details
    Browse the repository at this point in the history

  2. Ugh handle no image

    Eric Smith committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    a00f01e View commit details
    Browse the repository at this point in the history

  3. Fill in Nones

    Eric Smith committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    730ad07 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. Cleanup and enforce always having image features

    Eric Smith committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    2a01122 View commit details
    Browse the repository at this point in the history

  2. Let's be tough on tensors

    Eric Smith committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    929b20a View commit details
    Browse the repository at this point in the history

  3. Always use dummy features

    Eric Smith committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    b82678a View commit details
    Browse the repository at this point in the history

  4. Typo

    Eric Smith committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    00f42d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2020

  1. Delete additional teachers for now

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    2d3bf27 View commit details
    Browse the repository at this point in the history

  2. postpend -> append

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    6c146d6 View commit details
    Browse the repository at this point in the history

  3. Private methods

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    f0c1e1f View commit details
    Browse the repository at this point in the history

  4. Simplify

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    f5d489c View commit details
    Browse the repository at this point in the history

  5. Dump ImagePolyencoderAgent

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    431793f View commit details
    Browse the repository at this point in the history

  6. Split functionality

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    b954cdd View commit details
    Browse the repository at this point in the history

  7. Remove duplicated methods

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    a7748b4 View commit details
    Browse the repository at this point in the history

  8. Split remaining Agent code

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    d0bd597 View commit details
    Browse the repository at this point in the history

  9. Move Agent

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    bec4d63 View commit details
    Browse the repository at this point in the history

  10. Dump new model

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    e6a5e11 View commit details
    Browse the repository at this point in the history

  11. Refer to new model

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    54f6377 View commit details
    Browse the repository at this point in the history

  12. Don't duplicate code

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    0373ad5 View commit details
    Browse the repository at this point in the history

  13. Start to separate model

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    b2cbefe View commit details
    Browse the repository at this point in the history

  14. Start to split .encode()

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    683ac81 View commit details
    Browse the repository at this point in the history

  15. More DRY

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    d1b0bbc View commit details
    Browse the repository at this point in the history

  16. End of splitting

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    355fcf6 View commit details
    Browse the repository at this point in the history

  17. Remove flag

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    33fc1fb View commit details
    Browse the repository at this point in the history

  18. Tweak defaults

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    51f96a1 View commit details
    Browse the repository at this point in the history

  19. Yes - added

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    bbd6460 View commit details
    Browse the repository at this point in the history

  20. warn_once

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    ca03db3 View commit details
    Browse the repository at this point in the history

  21. Remove unneeded giant function

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    ddc6f02 View commit details
    Browse the repository at this point in the history

  22. Cosmetic

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    1b266a7 View commit details
    Browse the repository at this point in the history

  23. Avoid a lot of repeated code

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    4d2f125 View commit details
    Browse the repository at this point in the history

  24. Revert old code

    @EricMichaelSmith
    EricMichaelSmith committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    5eb08fe View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2020

  1. Name change

    @EricMichaelSmith
    EricMichaelSmith committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    e3b1f7a View commit details
    Browse the repository at this point in the history

  2. Update docstring

    @EricMichaelSmith
    EricMichaelSmith committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    b2b8f72 View commit details
    Browse the repository at this point in the history

  3. Split into separate module

    @EricMichaelSmith
    EricMichaelSmith committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    56608ab View commit details
    Browse the repository at this point in the history

  4. Fix kwarg issue

    @EricMichaelSmith
    EricMichaelSmith committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    9c35126 View commit details
    Browse the repository at this point in the history

  5. Change a variable named "dict"

    Eric Smith committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    8c8c799 View commit details
    Browse the repository at this point in the history

  6. Reduction type fix

    Eric Smith committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    6ee97b3 View commit details
    Browse the repository at this point in the history

  7. No, have to use kwargs

    Eric Smith committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    3f9272f View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2020

  1. Fix getattr() bug

    Eric Smith committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    b85b06f View commit details
    Browse the repository at this point in the history

  2. Same trick for the context encoder

    Eric Smith committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    8cf287b View commit details
    Browse the repository at this point in the history

  3. Use right encoder types

    Eric Smith committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    9e00af8 View commit details
    Browse the repository at this point in the history

  4. Remove unneeded method

    Eric Smith committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    b98194c View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Autoformat

    Eric Smith committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    2d19a3a View commit details
    Browse the repository at this point in the history

  2. Multi-layer image encoder fix

    Eric Smith committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    5a95902 View commit details
    Browse the repository at this point in the history

  3. TorchImageAgent

    @EricMichaelSmith
    EricMichaelSmith committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    139c6cf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into polyencoder-with-image

    Eric Smith committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    32a1b26 View commit details
    Browse the repository at this point in the history

  5. Fix adding args

    Eric Smith committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    bdf02d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. CPU fix

    Eric Smith committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    de1b6b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. Allow multiple image tokens

    Eric Smith committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    f9acfc9 View commit details
    Browse the repository at this point in the history

  2. Formatting

    Eric Smith committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    aed9983 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2020

  1. Name consistency

    Eric Smith committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    7cc5822 View commit details
    Browse the repository at this point in the history

  2. Partial fix for token-dim issue

    Eric Smith committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    f329f56 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2020

  1. Rest of fp16 function

    Eric Smith committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    e65c426 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Dump previous test

    @EricMichaelSmith
    EricMichaelSmith committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    b0931e3 View commit details
    Browse the repository at this point in the history

  2. Revamp basic task

    @EricMichaelSmith
    EricMichaelSmith committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    8442ce4 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Set up image polyencoder test

    Eric Smith committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    fa301e9 View commit details
    Browse the repository at this point in the history

  2. Change output message

    Eric Smith committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    da37eea View commit details
    Browse the repository at this point in the history

  3. Minor test tweaks

    Eric Smith committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    2b1897a View commit details
    Browse the repository at this point in the history

  4. Bad mode

    Eric Smith committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    76ac292 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Token fix

    Eric Smith committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    4028578 View commit details
    Browse the repository at this point in the history

  2. Fix

    Eric Smith committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    1ad5826 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2020

  1. Deal with no image features

    Eric Smith committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    a0a70e5 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Merge branch 'master' into polyencoder-with-image

    @EricMichaelSmith
    EricMichaelSmith authored Mar 10, 2020
    Configuration menu
    Copy the full SHA
    61a9be6 View commit details
    Browse the repository at this point in the history

  2. Segments fix

    Eric Smith committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    003f302 View commit details
    Browse the repository at this point in the history

  3. Fix test

    Eric Smith committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    75c2b96 View commit details
    Browse the repository at this point in the history

  4. autoformat

    Eric Smith committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    81ceabf View commit details
    Browse the repository at this point in the history

  5. Add commit string

    @EricMichaelSmith
    EricMichaelSmith committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    2213d42 View commit details
    Browse the repository at this point in the history

  6. Silently delete param

    @EricMichaelSmith
    EricMichaelSmith committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    f5f58d8 View commit details
    Browse the repository at this point in the history

  7. Minor

    @EricMichaelSmith
    EricMichaelSmith committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    adc95a1 View commit details
    Browse the repository at this point in the history

  8. mypy

    @EricMichaelSmith
    EricMichaelSmith committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    aa0bf20 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Overhaul task

    Eric Smith committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    b08b979 View commit details
    Browse the repository at this point in the history

  2. More tasks

    Eric Smith committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    c1f549b View commit details
    Browse the repository at this point in the history

  3. fp16 in new function

    Eric Smith committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    eb54800 View commit details
    Browse the repository at this point in the history

  4. Minor

    Eric Smith committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    ff7dd95 View commit details
    Browse the repository at this point in the history

  5. Cosmetic

    Eric Smith committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    0f6f4fc View commit details
    Browse the repository at this point in the history

  6. More description

    Eric Smith committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    9737599 View commit details
    Browse the repository at this point in the history

  7. [long] Assert

    Eric Smith committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    9e5049b View commit details
    Browse the repository at this point in the history

  8. mypy tweaks

    Eric Smith committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    ed1d59c View commit details
    Browse the repository at this point in the history

  9. Make tests faster

    Eric Smith committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    7b4fd65 View commit details
    Browse the repository at this point in the history

  10. Increase time image test has

    Eric Smith committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    6d0b994 View commit details
    Browse the repository at this point in the history

  11. Make test easier

    Eric Smith committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    b053eb2 View commit details
    Browse the repository at this point in the history