Online lira NaN filtering and squared_error as a new score type#112
Closed
lucamelis wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Online lira NaN filtering and squared_error as a new score type#112lucamelis wants to merge 1 commit intofacebookresearch:mainfrom
lucamelis wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
|
@lucamelis has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95680183. |
meta-cla
bot
added
the
CLA Signed
iden-kalemaj
approved these changes
Mar 10, 2026
Contributor
iden-kalemaj
left a comment
iden-kalemaj
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
…bookresearch#112) Summary: Pull Request resolved: facebookresearch#112 * Filter out NaN values after merging holdout train and test (plus LiRA run attack return arg type change) * Added squared_error Reviewed By: iden-kalemaj Differential Revision: D95680183
lucamelis
force-pushed
the
export-D95680183
branch
from
c7b2db5 to
bf23a70
Compare
|
This pull request has been merged in 6ee4f9c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reviewed By: iden-kalemaj
Differential Revision: D95680183