Skip parallel analysis node tests which hang in pytest full runs#75
Closed
mgrange1998 wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Skip parallel analysis node tests which hang in pytest full runs#75mgrange1998 wants to merge 1 commit intofacebookresearch:mainfrom
mgrange1998 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: The PrivacyGuard Github actions began timing out on the parallel analysis nodes compute_outputs test. ## Changes - Skips the two timing out tests - Adds a overall timeout to the Github ## Investigation I investigated into the root cause, and found the following 1. The tests fail only when the full test suite is called. Running pytest on the specific file does not cause failure 2. These tests hang when both running `pytest` and `pytest --timeout=120` Differential Revision: D83752642
meta-cla
bot
added
the
CLA Signed
|
@mgrange1998 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83752642. |
Contributor
|
This pull request has been merged in 0cce9e9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The PrivacyGuard Github actions began timing out on the parallel analysis nodes compute_outputs test.
Changes
Investigation
I investigated into the root cause, and found the following
pytestandpytest --timeout=120Differential Revision: D83752642