Make some methods static to help with factorization#77
Closed
iden-kalemaj wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Make some methods static to help with factorization#77iden-kalemaj wants to merge 1 commit intofacebookresearch:mainfrom
iden-kalemaj wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@iden-kalemaj has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84386974. |
iden-kalemaj
force-pushed
the
export-D84386974
branch
from
96cc019 to
81f43e9
Compare
Summary: Make _compute_ci and _compute_bootstrap_indices static to help with factorizing other analysis classes. Reviewed By: lucamelis Differential Revision: D84386974
iden-kalemaj
force-pushed
the
export-D84386974
branch
from
81f43e9 to
ee5b5d5
Compare
|
This pull request has been merged in 6c20f64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Make _compute_ci and _compute_bootstrap_indices static to help with factorizing other analysis classes.
Differential Revision: D84386974