GenerationAttack and HuggingFace predictor updates#84
Closed
mgrange1998 wants to merge 1 commit intofacebookresearch:mainfrom
Closed
GenerationAttack and HuggingFace predictor updates#84mgrange1998 wants to merge 1 commit intofacebookresearch:mainfrom
mgrange1998 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@mgrange1998 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87341640. |
mgrange1998
added a commit
to mgrange1998/PrivacyGuard-1
that referenced
this pull request
Nov 21, 2025
Summary: This change updates GenerationAttack and HuggingFace predictor with the following functionality. - Fixes "batch_size=self.batch_size" s.t it is propagated downstream properly. Updated the default value to 1 to reflect intended behavior - Adds "_generate_decode_logic" helper to encapsulate calling "model.generate" - Extends generation functionality to not include prompt when decoding Differential Revision: D87341640
mgrange1998
force-pushed
the
export-D87341640
branch
from
fe4df99 to
89b0af4
Compare
mgrange1998
added a commit
to mgrange1998/PrivacyGuard-1
that referenced
this pull request
Nov 21, 2025
Summary: This change updates GenerationAttack and HuggingFace predictor with the following functionality. - Fixes "batch_size=self.batch_size" s.t it is propagated downstream properly. Updated the default value to 1 to reflect intended behavior - Adds "_generate_decode_logic" helper to encapsulate calling "model.generate" - Extends generation functionality to not include prompt when decoding Differential Revision: D87341640
Summary: This change updates GenerationAttack and HuggingFace predictor with the following functionality. - Fixes "batch_size=self.batch_size" s.t it is propagated downstream properly. Updated the default value to 1 to reflect intended behavior - Adds "_generate_decode_logic" helper to encapsulate calling "model.generate" - Extends generation functionality to not include prompt when decoding Reviewed By: lucamelis Differential Revision: D87341640
mgrange1998
force-pushed
the
export-D87341640
branch
from
89b0af4 to
efe3d18
Compare
mgrange1998
added a commit
to mgrange1998/PrivacyGuard-1
that referenced
this pull request
Nov 24, 2025
Summary: This change updates GenerationAttack and HuggingFace predictor with the following functionality. - Fixes "batch_size=self.batch_size" s.t it is propagated downstream properly. Updated the default value to 1 to reflect intended behavior - Adds "_generate_decode_logic" helper to encapsulate calling "model.generate" - Extends generation functionality to not include prompt when decoding Reviewed By: lucamelis Differential Revision: D87341640
|
This pull request has been merged in 0cf30f9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change updates GenerationAttack and HuggingFace predictor with the following functionality.
Differential Revision: D87341640