Explorer: Embed video in an in-page overlay - #22
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
Replaces the header 'Video' link's external YouTube redirect with an in-page modal overlay (same UX pattern as About). The iframe loads only on open and is cleared after the fade-out so playback stops cleanly. Refactors the modal wiring into a generic setupModal() helper that handles backdrop click, Escape key, and any descendant [data-modal-close] button, with optional onOpen/onClose hooks. Both About and Video modals now share this helper.
SebastianAment
force-pushed
the
video-overlay-pr
branch
from
May 15, 2026 13:46
3b6f721 to
a4efa0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the header Video link's external YouTube redirect with an
in-page modal overlay (same UX pattern as the existing About modal).
Visitors stay on the explorer page while watching.
Implementation notes
srcis set on open (lazy load — no page-load cost) andcleared
250msafter close (matches the overlay fade transition, sothere's no black flash before the modal disappears).
setupModal(overlay, { onOpen, onClose })helper. Both About and Video modals share it. Close behavior is
declarative: any descendant element with
[data-modal-close]becomesa close button; backdrop click and Escape are handled centrally.
youtube-nocookie.comfor the embed (privacy-enhanced).frameborder="0"HTML attribute (CSS alreadyenforces
border: 0).