Skip to content

Add qLogNEHVI optimization, fix FixedFeatureModel index bug - #8

Merged
SebastianAment merged 1 commit into
mainfrom
fix-pareto-and-polish
Mar 18, 2026
Merged

Add qLogNEHVI optimization, fix FixedFeatureModel index bug#8
SebastianAment merged 1 commit into
mainfrom
fix-pareto-and-polish

Conversation

@SebastianAment

Copy link
Copy Markdown
Contributor

Changes:

  • Add qLogNEHVI acquisition function optimization section to notebook
  • Fix critical bug: FixedFeatureModel placed values at wrong positions when indices were unsorted (e.g. Time=28 and MaterialSource=0 swapped)
  • Calibrate CONCRETE_BOUNDS_DICT to training data with ~20% margin
  • Add mode-specific reference points (MORTAR/CONCRETE_REFERENCE_POINT)
  • Add regression tests for both bugs (unsorted indices, bounds range)
  • Move coverage config to pyproject.toml, matplotlib as core dependency
  • Clean notebook metadata, rename figures, restructure README
  • 84 tests, 100% coverage

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2026
@SebastianAment
SebastianAment force-pushed the fix-pareto-and-polish branch from a7bf966 to e487e0b Compare March 18, 2026 20:10
…mization

- Fix critical bug: FixedFeatureModel placed values at wrong positions
  when indices were unsorted (e.g. Time=28 and MaterialSource=0 swapped)
- Calibrate CONCRETE_BOUNDS_DICT to training data with ~20% margin
- Add mode-specific reference points (MORTAR/CONCRETE_REFERENCE_POINT)
- Add qLogNEHVI acquisition function optimization section to notebook
- Add regression tests for both bugs (unsorted indices, bounds range)
- Move coverage config to pyproject.toml, matplotlib as core dependency
- Clean notebook metadata, rename figures, restructure README
- 84 tests, 100% coverage
@SebastianAment
SebastianAment force-pushed the fix-pareto-and-polish branch from e487e0b to e3997e7 Compare March 18, 2026 21:12
@SebastianAment
SebastianAment merged commit ad73603 into main Mar 18, 2026
11 checks passed
@SebastianAment
SebastianAment deleted the fix-pareto-and-polish branch March 18, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant