Refactor factories to use classes and use configurablemixin#793
Closed
JasonKChow wants to merge 1 commit into
Closed
Refactor factories to use classes and use configurablemixin#793JasonKChow wants to merge 1 commit into
JasonKChow wants to merge 1 commit into
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74040481 |
c841ee8 to
bdc12ba
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
May 2, 2025
…research#793) Summary: Factory classes to create mean and covariance modules has been refactored to use ConfigurableMixin. This means they follow the same from_config API as all other classes that can be initialized from a config. The old functions are now deprecated and will warn. Differential Revision: D74040481
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74040481 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
May 2, 2025
…research#793) Summary: Factory classes to create mean and covariance modules has been refactored to use ConfigurableMixin. This means they follow the same from_config API as all other classes that can be initialized from a config. The old functions are now deprecated and will warn. Differential Revision: D74040481
bdc12ba to
23f7b09
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74040481 |
23f7b09 to
bc71edd
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
May 2, 2025
…research#793) Summary: Factory classes to create mean and covariance modules has been refactored to use ConfigurableMixin. This means they follow the same from_config API as all other classes that can be initialized from a config. The old functions are now deprecated and will warn. Differential Revision: D74040481
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74040481 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
May 5, 2025
…research#793) Summary: Factory classes to create mean and covariance modules has been refactored to use ConfigurableMixin. This means they follow the same from_config API as all other classes that can be initialized from a config. The old functions are now deprecated and will warn. Differential Revision: D74040481
bc71edd to
7b4d27f
Compare
…research#793) Summary: Pull Request resolved: facebookresearch#793 Factory classes to create mean and covariance modules has been refactored to use ConfigurableMixin. This means they follow the same from_config API as all other classes that can be initialized from a config. The old functions are now deprecated and will warn. Differential Revision: D74040481
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74040481 |
7b4d27f to
434f64f
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
May 5, 2025
…research#793) Summary: Factory classes to create mean and covariance modules has been refactored to use ConfigurableMixin. This means they follow the same from_config API as all other classes that can be initialized from a config. The old functions are now deprecated and will warn. Differential Revision: D74040481
JasonKChow
pushed a commit
to JasonKChow/aepsych
that referenced
this pull request
May 5, 2025
…research#793) Summary: Pull Request resolved: facebookresearch#793 Factory classes to create mean and covariance modules has been refactored to use ConfigurableMixin. This means they follow the same from_config API as all other classes that can be initialized from a config. The old functions are now deprecated and will warn. Differential Revision: D74040481
Contributor
|
This pull request has been merged in 3f5b73a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Factory classes to create mean and covariance modules has been refactored to use ConfigurableMixin. This means they follow the same from_config API as all other classes that can be initialized from a config.
The old functions are now deprecated and will warn.
Differential Revision: D74040481