Temporary attribute context manager for factories#794
Closed
JasonKChow wants to merge 2 commits into
Closed
Conversation
…research#793) Summary: Factory classes to create mean and covariance modules has been refactored to use ConfigurableMixin. This means they follow the same from_config API as all other classes that can be initialized from a config. The old functions are now deprecated and will warn. Differential Revision: D74040481
Summary: Utility context manager that allows us to temporarily modify the class attributes of a factory to make a module for a subclass. Now used in the pairwise factory. Differential Revision: D74192292
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74192292 |
Contributor
|
This pull request has been merged in de1df6f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Utility context manager that allows us to temporarily modify the class attributes of a factory to make a module for a subclass. Now used in the pairwise factory.
Differential Revision: D74192292