-
Notifications
You must be signed in to change notification settings - Fork 47
Migrate test_rake.py to pyre-strict mode #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+60
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a497ab3 to
0dd065d
Compare
|
@talgalili has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87727292. |
0dd065d to
fdf955d
Compare
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
fdf955d to
ce75b2d
Compare
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
ce75b2d to
9afbb30
Compare
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
9afbb30 to
aa543e6
Compare
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 23, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
Summary: Migrated test_poststratify.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_poststratify.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Reviewed By: wesleytlee Differential Revision: D87727288
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
aa543e6 to
5944818
Compare
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 24, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 24, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 24, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
talgalili
added a commit
to talgalili/balance
that referenced
this pull request
Nov 24, 2025
Summary: Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite. Changes: - Converted test_rake.py from # pyre-unsafe to # pyre-strict - Updated file header to use from __future__ import annotations for modern type hint support - Added comprehensive type annotations for all test functions and helper variables - Fixed type handling throughout test cases to satisfy strict mode requirements All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions. Differential Revision: D87727292
|
This pull request has been merged in 54476fa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Migrated test_rake.py from # pyre-unsafe to # pyre-strict mode as part of the comprehensive type safety improvements in the balance test suite.
Changes:
All test cases pass without modifications to test logic - the changes are purely type annotation improvements that enhance code maintainability and prevent future type safety regressions.
Differential Revision: D87727292