Refactor _auto_bar_width and add _auto_bar_width_columnar

[talgalili]

Summary:
Refactored the _auto_bar_width function to simplify its interface by removing the unused n_datasets parameter, and extracted the columnar layout logic into a new dedicated _auto_bar_width_columnar function.

The original _auto_bar_width was trying to serve two different purposes but the n_datasets parameter wasn't actually used in the calculation. This change:

• Simplifies _auto_bar_width for single-bar-per-line layouts (grouped barplots and histograms)
• Adds _auto_bar_width_columnar specifically for side-by-side columnar layouts used by ascii_comparative_hist
• Improves code clarity by having separate functions with clear docstrings for each use case
• Removed Overriding n_bins and bar_width example from balance_ascii_plots.ipynb

Reviewed By: talgalili

Differential Revision: D94465988

[meta-codesync]

@talgalili has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94465988.

[Copilot]

Pull request overview

This PR refactors the ASCII plotting functions to better separate concerns and simplify the bar width calculation logic. The main goal is to distinguish between single-bar-per-line layouts (grouped barplots and histograms) and columnar side-by-side layouts (comparative histograms).

Changes:

• Simplified _auto_bar_width by removing the unused n_datasets parameter
• Added dedicated _auto_bar_width_columnar function for columnar layouts with proper space accounting for multiple columns
• Changed ascii_plot_dist to use ascii_comparative_hist for numeric variables instead of ascii_plot_hist, resulting in a different output format (columnar vs. multi-line)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
balance/stats_and_plots/ascii_plots.py	Refactored _auto_bar_width to remove unused parameter, added _auto_bar_width_columnar for columnar layouts, updated ascii_plot_dist to use ascii_comparative_hist, updated docstrings and examples
tests/test_ascii_plots.py	Updated tests to call _auto_bar_width with one parameter, added tests for _auto_bar_width_columnar, updated expected outputs to match new comparative histogram format
tutorials/balance_ascii_plots.ipynb	Removed section 6 about overriding n_bins and bar_width parameters, consolidated tutorial introduction

Comments suppressed due to low confidence (1)

balance/stats_and_plots/ascii_plots.py:786

• This is a breaking change in the output format for numeric variables in ascii_plot_dist. Previously it used ascii_plot_hist which shows each dataset on a separate line within each bin. Now it uses ascii_comparative_hist which shows all datasets as columns on the same line. According to the coding guidelines (review checklist item 5), breaking changes must be explicitly labeled in the CHANGELOG with migration notes and before/after examples. This change should be documented in the CHANGELOG.md file under "Breaking Changes".

                ascii_comparative_hist(

[meta-codesync]

@sahil350 has imported this pull request. If you are a Meta employee, you can view this in D94465988.

[neuralsorcerer]

Closing this PR since the changes have already been committed.

[talgalili]

Thanks @neuralsorcerer