Make test coverage 100%#349
Closed
neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds additional unit tests to improve coverage of the ASCII plot dispatcher (ascii_plot_dist), specifically for the comparative=False numeric-plot path, and documents the coverage expansion in the changelog.
Changes:
- Added tests ensuring
ascii_plot_dist(..., comparative=False)dispatches numeric variables toascii_plot_hist(notascii_comparative_hist). - Added a mixed categorical+numeric test to verify correct routing in a single call when
comparative=False. - Updated
CHANGELOG.mdto reflect the added ASCII plot dispatcher test coverage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_ascii_plots.py | Adds dispatcher edge-case tests for comparative=False behavior. |
| CHANGELOG.md | Notes the expanded test coverage for ASCII plot dispatching. |
|
@talgalili has imported this pull request. If you are a Meta employee, you can view this in D94819811. |
|
@talgalili merged this pull request in d174ee0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.