Align model_matrix input errors and docs

[neuralsorcerer]

No description provided.

[Copilot]

Pull request overview

This PR updates documentation to better explain how model-matrix inputs are prepared, and records the doc clarification in the changelog.

Changes:

• Expanded _prepare_input_model_matrix docstring argument descriptions (sample, target, variables, add_na, fix_columns_names).
• Added a changelog entry under Documentation noting the clarification.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
balance/utils/model_matrix.py	Clarifies _prepare_input_model_matrix argument behavior in the docstring.
CHANGELOG.md	Notes the docstring clarification under the Documentation section.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

tests/test_util_model_matrix.py:299

• This test uses pd.DataFrame() (zero rows and zero columns). Since the intent is specifically “zero rows”, consider constructing an empty frame with representative columns (e.g., pd.DataFrame(columns=[...])) so the assertion is unambiguous and continues to validate the intended contract if column-handling changes.

        # Test zero rows error:
        self.assertRaisesRegex(
            ValueError,
            "sample must have more than zero rows",
            model_matrix,
            pd.DataFrame(),
        )

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[talgalili]

LGTM.
Might take a day to land.

[meta-codesync]

@talgalili has imported this pull request. If you are a Meta employee, you can view this in D94872326.

[meta-codesync]

@talgalili merged this pull request in 93c62b6.