Skip to content
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@
- Added tests for `ascii_plot_dist` with `comparative=False` to verify direct dispatch to `ascii_plot_hist` and mixed categorical+numeric routing in a single call.
- **Expanded `prop_above_and_below()` edge-case coverage**
- Added focused tests for empty threshold iterables, mixed `None` threshold groups in dict mode, and explicit all-`None` threshold handling across return formats.
- **Expanded IPW diagnostics coverage for fit-parameter reporting**
- Refactored diagnostics tests to use a shared IPW setup helper (removing repeated fixture construction) and added edge-case assertions for filtered non-string solver/penalty values and NaN coercion of non-scalar `tol`/`l1_ratio` inputs.

# 0.16.0 (2026-02-09)

Expand Down
3 changes: 0 additions & 3 deletions balance/sample_class.py
Original file line number Diff line number Diff line change
Expand Up @@ -1894,7 +1894,6 @@ def diagnostics(

fit_list: List[pd.DataFrame] = []

# TODO: add tests checking these values
for array_key in ("n_iter_", "intercept_"):
array_val = getattr(fit, array_key, None)
if array_val is None:
Expand All @@ -1911,7 +1910,6 @@ def diagnostics(
)
)

# TODO: add tests checking these values
for param_key, metric_name in (
("penalty", "ipw_penalty"),
("solver", "ipw_solver"),
Expand All @@ -1934,7 +1932,6 @@ def diagnostics(
)
)

# TODO: add tests checking these values
multi_class = params.get("multi_class", getattr(fit, "multi_class", None))
if multi_class is None:
multi_class = "auto"
Expand Down
Loading
Loading