Skip to content

New FastCSP release: update to docs/example/configs/correctors - #2076

Merged
gvahe merged 4 commits into
mainfrom
fastcsp_v2_release
Jul 8, 2026
Merged

New FastCSP release: update to docs/example/configs/correctors#2076
gvahe merged 4 commits into
mainfrom
fastcsp_v2_release

Conversation

@gvahe

@gvahe gvahe commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@meta-cla meta-cla Bot added the cla signed label Jul 7, 2026
@gvahe gvahe added documentation Improvements or additions to documentation enhancement New feature or request minor Minor version release labels Jul 7, 2026
@gvahe
gvahe requested a review from lbluque July 7, 2026 06:50
@gvahe
gvahe enabled auto-merge July 7, 2026 18:44

@lbluque lbluque left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gvahe. Just minor comments/questions

input_df["correction.e_fragments_corrector"] = sum_corr
input_df["correction.e_fragments_corrector_per_molecule"] = sum_corr / z_arr
input_df["energy_corrected"] = e_relaxed - sum_orig + sum_corr
input_df["energy_corrected_per_molecule"] = input_df["energy_corrected"] / z_arr

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the corrected energy ever used in filter? It looks like it will be used when removing problematic structures here (using "validity.conformer_corrections.applied") here:

validity_cols = [
col for col in structures_df.columns if col.startswith("validity.")
]
all_valid = structures_df[validity_cols].all(axis=1)

But is "energy_corrected_per_molecule" every used for ranking, filtering or free energy? Looks like only "energy_relaxed_per_molecule" is used.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. It was not but one can make it to ;) If smth is wrong with the energy correction validity calculations, we don't want to use it downstream anyway. We accounted exactly 0 such cases. As long as Z_check passes, correction is correctly computed.

Comment thread src/fairchem/applications/fastcsp/core/utils/structure.py Outdated
Comment thread src/fairchem/applications/fastcsp/core/utils/structure.py
@gvahe
gvahe requested a review from lbluque July 8, 2026 05:49

@lbluque lbluque left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@gvahe
gvahe added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit f7dec8d Jul 8, 2026
26 checks passed
@gvahe
gvahe deleted the fastcsp_v2_release branch July 8, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed documentation Improvements or additions to documentation enhancement New feature or request minor Minor version release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants