Restore test_full_model_gp_correctness in test_predict.py - #2148
Merged
Conversation
Re-add the full-model GP correctness test (no-GP / allgather / A2A-spatial / A2A-index_split at 1/2/4 workers vs single-GPU reference on energy/forces/ stress), which was silently dropped during an earlier main merge. Adapted to the current gp_config=GraphParallelConfig(...) API and the pretrained fixture convention. Referenced by graph_parallel_verification.md section 1d.
rayg1234
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-add the full-model GP correctness test (no-GP / allgather / A2A-spatial / A2A-index_split at 1/2/4 workers vs single-GPU reference on energy/forces/ stress), which was silently dropped during an earlier main merge. Adapted to the current gp_config=GraphParallelConfig(...) API and the pretrained fixture convention. Referenced by graph_parallel_verification.md section 1d.