Skip to content

gp test fixes - #2165

Open
wood-b wants to merge 1 commit into
mainfrom
gp_test_fix_bw
Open

gp test fixes#2165
wood-b wants to merge 1 commit into
mainfrom
gp_test_fix_bw

Conversation

@wood-b

@wood-b wood-b commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

fixed some GPU gp test issues

@meta-cla meta-cla Bot added the cla signed label Aug 13, 2026
@wood-b
wood-b requested a review from rayg1234 August 13, 2026 23:53
@wood-b wood-b added bug Something isn't working minor Minor version release labels Aug 13, 2026
dst.append(j)
edge_index = torch.tensor([src, dst], dtype=torch.long)

config = PGConfig(backend="nccl", world_size=2, gp_group_size=2, use_gp=True)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: lets parameterize the total gp size and number of gpus at the top so we dont have inconsisntencies in the future between number of gpus needed and gp size

@rayg1234 rayg1234 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla signed minor Minor version release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants