Skip to content

Mutualize audio readings #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
May 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/fairseq2/data/parquet/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ class BasicDataLoadingConfig:

# default trivial config will load all columns
fragment_load_config: FragmentLoadingConfig = field(
default=lambda: FragmentLoadingConfig()
default_factory=lambda: FragmentLoadingConfig()
)

# default trivial config applies NO bucketing
table_bucketing_config: TableBucketingConfig = field(
default=lambda: TableBucketingConfig()
default_factory=lambda: TableBucketingConfig()
)


Expand Down
17 changes: 13 additions & 4 deletions src/fairseq2/data/parquet/fragment_loading/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@
from retrying import retry

from fairseq2.data import DataPipelineBuilder
from fairseq2.data.parquet.arrow_transform import (
apply_filter,
)
from fairseq2.data.parquet.arrow_transform import apply_filter
from fairseq2.data.parquet.fragment_loading.config import FragmentLoadingConfig
from fairseq2.data.parquet.fragment_streaming.primitives import process_filter
from fairseq2.data.parquet.utils import (
Expand Down Expand Up @@ -48,6 +46,13 @@ class SafeFragment:

def __init__(self, fragment: pa.dataset.ParquetFileFragment):
self.fragment = fragment
self.memory_pool = None
try:
self.memory_pool = pa.jemalloc_memory_pool()
pa.jemalloc_set_decay_ms(10)
except pa.ArrowNotImplementedError:
log.info("jemalloc not available, skipping memory pool init")
pass

def __repr__(self) -> str:
out = ""
Expand Down Expand Up @@ -105,6 +110,7 @@ def load(
columns=fragment_columns,
use_threads=use_threads,
filter=filters if can_apply_on_phyiscal_schema else None,
memory_pool=self.memory_pool,
)

if add_partitioning_columns:
Expand Down Expand Up @@ -139,13 +145,16 @@ def __init__(self, config: FragmentLoadingConfig) -> None:

def apply(self, fragment_pipeline: DataPipelineBuilder) -> DataPipelineBuilder:
def load_fn(fragment: pa.dataset.ParquetFileFragment) -> pa.Table | None:
return SafeFragment(fragment).load(
safe_fragment = SafeFragment(fragment)

table = safe_fragment.load(
columns=self.columns,
add_fragment_traces=self.config.add_fragment_traces,
use_threads=self.config.use_threads,
filters=self.filters,
add_partitioning_columns=True,
)
return table

if self.config.non_deterministic_read:
# keeping if above checks for back-compatibility
Expand Down
Loading
Loading