Main parquet text loader - #1220
Merged
Merged
Conversation
artemru
commented
Jun 30, 2025
| max_num_elements + 1, max_seq_len, truncate=True, pinned_memory=True | ||
| max_num_elements + 1, | ||
| max_seq_len, | ||
| pad_value=pad_idx, |
Contributor
Author
There was a problem hiding this comment.
@cbalioglu : pad_value is not documented, I hope I used it correctly
artemru
commented
Jun 30, 2025
| min_seq_len: int, | ||
| max_seq_len: int, | ||
| options: TextReadOptions | None = None, | ||
| split: str | None = None, |
Contributor
Author
There was a problem hiding this comment.
this will keep the previous behaviour by default
added 2 commits
June 30, 2025 03:53
zyaoj
requested changes
Jul 6, 2025
zyaoj
approved these changes
Jul 7, 2025
zyaoj
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for addressing the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? Please describe:
Does your PR introduce any breaking changes? If yes, please list them:
No BC, only new feature
Check list:
Minimal working example