Skip to content

Jacklanchantin/fix online dpo rm args - #1233

Merged
jacklanchantin merged 4 commits into
online_trainingfrom
jacklanchantin/fix_online_dpo_rm_args
Jul 25, 2025
Merged

Jacklanchantin/fix online dpo rm args#1233
jacklanchantin merged 4 commits into
online_trainingfrom
jacklanchantin/fix_online_dpo_rm_args

Conversation

@jacklanchantin

@jacklanchantin jacklanchantin commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

What does this PR do? Please describe:
Fixes online DPO reward model input args (now matches GRPO)

Fixes #{issue number}

Does your PR introduce any breaking changes? If yes, please list them:
List of all backwards-incompatible changes.

Check list:

  • Was the content of this PR discussed and approved via a GitHub issue? (no need for typos or documentation improvements)
  • Did you read the contributor guideline?
  • Did you make sure that your PR does only one thing instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (no need for typos, documentation, or minor internal changes)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2025
@jacklanchantin
jacklanchantin changed the base branch from main to online_training July 25, 2025 01:11
@jacklanchantin
jacklanchantin marked this pull request as ready for review July 25, 2025 05:45
@jacklanchantin
jacklanchantin merged commit 11a8e5f into online_training Jul 25, 2025
6 of 13 checks passed
@jacklanchantin
jacklanchantin deleted the jacklanchantin/fix_online_dpo_rm_args branch July 25, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants