update fsdp1/2 state dict - save replicated items on all shards - #1247
Merged
cbalioglu merged 2 commits intoAug 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? Please describe:
When using fsdp1/2, replicated items (e.g. model buffer) are only saved to rank 0 (fsdp1, fsdp2). However, when continue training from sharded model checkpoints from fsdp1/2, we don't retrieve and load those replicated items from sdp_00.pt. This PR fixes the subtle bug by retiring the small optimization of model buffer de-dup.
Does your PR introduce any breaking changes? If yes, please list them:
N/A
Does your PR introduce any breaking changes? If yes, please list them:
List of all backwards-incompatible changes.
Check list: