Hoist SIMD dispatch out of approx_topk hot loops#5073
Open
algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
Open
Hoist SIMD dispatch out of approx_topk hot loops#5073algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: Three call sites dispatch SIMD level inside hot loops via HeapWithBuckets::bs_addn(), which calls with_simd_level_256bit on every invocation. The SIMD level is constant for the process lifetime, so this is pure overhead. - LocalSearchQuantizer::icm_encode_step: dispatch was inside n × n_iters × M loop. Wrap omp parallel for in with_simd_level_256bit, call HeapWithBucketsCMaxFloat<16,1,SL> directly. - residual_quantizer_encode_steps.cpp (2 call sites): dispatch per iteration of n-parallel loops. Hoist outside omp loop. For the second site, merge with the existing with_simd_level_256bit for compute_cent_distances_simd. - Add approx_topk_by_mode<SL>() helper to approx_topk.h to consolidate the duplicated switch(approx_topk_mode) blocks. Differential Revision: D100169491
Contributor
|
@algoriddle has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100169491. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Three call sites dispatch SIMD level inside hot loops via
HeapWithBuckets::bs_addn(), which calls with_simd_level_256bit on
every invocation. The SIMD level is constant for the process lifetime,
so this is pure overhead.
LocalSearchQuantizer::icm_encode_step: dispatch was inside
n × n_iters × M loop. Wrap omp parallel for in
with_simd_level_256bit, call HeapWithBucketsCMaxFloat<16,1,SL>
directly.
residual_quantizer_encode_steps.cpp (2 call sites): dispatch per
iteration of n-parallel loops. Hoist outside omp loop. For the
second site, merge with the existing with_simd_level_256bit for
compute_cent_distances_simd.
Add approx_topk_by_mode() helper to approx_topk.h to
consolidate the duplicated switch(approx_topk_mode) blocks.
Differential Revision: D100169491