Hoist SIMD dispatch outside loops in 4 call sites#5074
Open
algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
Open
Hoist SIMD dispatch outside loops in 4 call sites#5074algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: Move `with_simd_level` / `with_simd_level_256bit` calls outside the enclosing loops so the SIMD level is resolved once rather than on every iteration. Sites fixed: - distances.cpp: knn_inner_products_by_idx, knn_L2sqr_by_idx - NeuralNet.cpp: ZnLUTCodec::encode - ClusteringInitialization.cpp: init_kmpp_plus_plus - residual_quantizer_encode_steps.cpp: beam_search_encode_step_tab Differential Revision: D100144174
Contributor
|
@algoriddle has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100144174. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move
with_simd_level/with_simd_level_256bitcalls outside theenclosing loops so the SIMD level is resolved once rather than on every
iteration.
Sites fixed:
Differential Revision: D100144174