Wire 512-bit QBS kernels into fast scan DD dispatch#5075
Open
algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
Open
Wire 512-bit QBS kernels into fast scan DD dispatch#5075algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: In DD mode, the QBS (bbs=32) accumulate path always used 256-bit kernels, even in the AVX512 per-ISA TU. The 512-bit kernels in kernels_simd512.h were dead because bare simdlib aliases resolve to _tpl<NONE> in DD mode, and 512-bit NONE types don't exist (empty primary templates). Fix: add function-local using declarations in both 512-bit kernel functions to bind types to explicit AVX512/AVX2 levels. Create accumulate_loops_512.h with FixedStorage512 (a non-virtual intermediate handler that bridges the AVX2→NONE type gap via storeu/loadu at the handler boundary) and the 512-bit QBS accumulate loop. Wire it into dispatching.h's ScannerMixIn behind an Differential Revision: D100151879
Contributor
|
@algoriddle has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100151879. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In DD mode, the QBS (bbs=32) accumulate path always used 256-bit kernels,
even in the AVX512 per-ISA TU. The 512-bit kernels in kernels_simd512.h
were dead because bare simdlib aliases resolve to _tpl in DD mode,
and 512-bit NONE types don't exist (empty primary templates).
Fix: add function-local using declarations in both 512-bit kernel functions
to bind types to explicit AVX512/AVX2 levels. Create accumulate_loops_512.h
with FixedStorage512 (a non-virtual intermediate handler that bridges the
AVX2→NONE type gap via storeu/loadu at the handler boundary) and the 512-bit
QBS accumulate loop. Wire it into dispatching.h's ScannerMixIn behind an
Differential Revision: D100151879