Replace SSE3 intrinsics in Index2Layer with portable scalar code#5076
Open
algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
Open
Replace SSE3 intrinsics in Index2Layer with portable scalar code#5076algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: Index2Layer's distance computers (DistanceXPQ4, Distance2xXPQ4) used raw SSE3 intrinsics guarded by #ifdef __SSE3__, with the #else branch throwing "not implemented for non-x64 platforms". Since pq.dsub is always 4, the inner loop is just 4 float ops per sub-vector — scalar code is simple and the compiler will auto-vectorize it. This makes Index2Layer work on ARM and removes the last raw SSE3 usage from the codebase. Differential Revision: D100144911
Contributor
|
@algoriddle has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100144911. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Index2Layer's distance computers (DistanceXPQ4, Distance2xXPQ4) used raw
SSE3 intrinsics guarded by #ifdef SSE3, with the #else branch throwing
"not implemented for non-x64 platforms". Since pq.dsub is always 4, the
inner loop is just 4 float ops per sub-vector — scalar code is simple and
the compiler will auto-vectorize it. This makes Index2Layer work on ARM
and removes the last raw SSE3 usage from the codebase.
Differential Revision: D100144911