Suppress non-const global variable warnings and fix security integer casts (#5092)#5092
Open
Suppress non-const global variable warnings and fix security integer casts (#5092)#5092
Conversation
Contributor
|
@junjieqi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100592783. |
junjieqi
added a commit
that referenced
this pull request
Apr 13, 2026
…casts (#5092) Summary: Pull Request resolved: #5092 Fix 32 `facebook-avoid-non-const-global-variables` warnings by adding NOLINT comments to intentionally mutable global stats objects and configuration variables that are part of the public API (e.g., `indexIVF_stats`, `hnsw_stats`, `check_compatible_for_merge_expensive_check`). These cannot be made const as they accumulate runtime statistics and provide runtime configuration. Fix 25 `facebook-security-vulnerable-integer-implicit-cast` warnings by adding explicit `static_cast<size_t>()` to one operand before integer multiplication to prevent overflow before widening. Also fix `clang-diagnostic-switch-enum` warnings by adding missing enum cases to switch statements, and various other minor lint fixes including NOLINT for `-inl.h` includes, `ShadowingClass` fix, and `BadImplicitCast` fix. Differential Revision: D100592783
junjieqi
force-pushed
the
export-D100592783
branch
from
e2ee532 to
4e41764
Compare
meta-codesync
bot
changed the title
junjieqi
added a commit
that referenced
this pull request
Apr 13, 2026
…casts (#5092) Summary: Pull Request resolved: #5092 Fix 32 `facebook-avoid-non-const-global-variables` warnings by adding NOLINT comments to intentionally mutable global stats objects and configuration variables that are part of the public API (e.g., `indexIVF_stats`, `hnsw_stats`, `check_compatible_for_merge_expensive_check`). These cannot be made const as they accumulate runtime statistics and provide runtime configuration. Fix 25 `facebook-security-vulnerable-integer-implicit-cast` warnings by adding explicit `static_cast<size_t>()` to one operand before integer multiplication to prevent overflow before widening. Also fix `clang-diagnostic-switch-enum` warnings by adding missing enum cases to switch statements, and various other minor lint fixes including NOLINT for `-inl.h` includes, `ShadowingClass` fix, and `BadImplicitCast` fix. Differential Revision: D100592783
junjieqi
force-pushed
the
export-D100592783
branch
from
4e41764 to
099acbe
Compare
junjieqi
added a commit
that referenced
this pull request
Apr 13, 2026
…casts (#5092) Summary: Pull Request resolved: #5092 Fix 32 `facebook-avoid-non-const-global-variables` warnings by adding NOLINT comments to intentionally mutable global stats objects and configuration variables that are part of the public API (e.g., `indexIVF_stats`, `hnsw_stats`, `check_compatible_for_merge_expensive_check`). These cannot be made const as they accumulate runtime statistics and provide runtime configuration. Fix 25 `facebook-security-vulnerable-integer-implicit-cast` warnings by adding explicit `static_cast<size_t>()` to one operand before integer multiplication to prevent overflow before widening. Also fix `clang-diagnostic-switch-enum` warnings by adding missing enum cases to switch statements, and various other minor lint fixes including NOLINT for `-inl.h` includes, `ShadowingClass` fix, and `BadImplicitCast` fix. Differential Revision: D100592783
junjieqi
force-pushed
the
export-D100592783
branch
from
099acbe to
e1366e3
Compare
added 4 commits
April 13, 2026 14:04
Summary:
Fix 59 `cppcoreguidelines-pro-type-member-init` lint warnings by adding `{}` value-initialization to uninitialized member fields across 17 files. This ensures all members are zero/null-initialized by default, preventing potential use of uninitialized values.
Affected files: Index.cpp, Index2Layer.cpp, IndexAdditiveQuantizer.cpp, IndexAdditiveQuantizerFastScan.h, IndexBinaryHash.h, IndexBinaryIVF.cpp, IndexFastScan.h, IndexHNSW.h, IndexIVF.h, IndexIVFAdditiveQuantizer.cpp, IndexIVFFastScan.h, IndexIVFFlat.h, IndexIVFPQ.cpp, IndexIVFPQ.h, IndexPQ.cpp, IndexPQ.h, IndexRowwiseMinMax.cpp.
Differential Revision: D100577736
Summary: Fix 136 `readability-braces-around-statements` lint warnings by adding braces to all single-line `if`, `else`, `for`, and `while` statements across 4 files: `IndexLSH.cpp` (14 issues), `IndexIVFPQ.cpp` (36 issues), `IndexPQ.cpp` (25 issues), and `VectorTransform.cpp` (61 issues). This improves code readability and prevents bugs from accidentally adding statements to unbraced blocks. Differential Revision: D100580151
Summary: Fix 172 `clang-diagnostic-shorten-64-to-32` lint warnings across 29 files by adding explicit `static_cast<int>()` or widening variable types where `size_t`/`idx_t` (64-bit) values were implicitly narrowed to `int`/`int32_t` (32-bit). The fixes fall into two categories: - **Explicit casts**: Where the receiving API requires `int` and the value is known to fit (e.g., vector dimensions, sub-quantizer counts, cluster counts, BLAS parameters) - **Type widening**: Where the variable was unnecessarily narrow (e.g., `int nprobe` → `size_t nprobe`, `int list_no` → `size_t list_no`) Differential Revision: D100588996
…tructors Summary: Fix 73 `cppcoreguidelines-special-member-functions` and `clang-diagnostic-deprecated-copy-with-user-provided-dtor` lint warnings across 32 header files by adding explicit `= default` declarations for copy/move constructors and assignment operators to 46 classes that define user-provided destructors. In C++17+, the implicit generation of copy constructors for classes with user-provided destructors is deprecated. Adding explicit `= default` preserves the existing behavior while satisfying the Rule of Five. Default constructors were also added where needed to maintain existing default-constructibility. Differential Revision: D100592061
junjieqi
added a commit
that referenced
this pull request
Apr 13, 2026
…casts (#5092) Summary: Pull Request resolved: #5092 Fix 32 `facebook-avoid-non-const-global-variables` warnings by adding NOLINT comments to intentionally mutable global stats objects and configuration variables that are part of the public API (e.g., `indexIVF_stats`, `hnsw_stats`, `check_compatible_for_merge_expensive_check`). These cannot be made const as they accumulate runtime statistics and provide runtime configuration. Fix 25 `facebook-security-vulnerable-integer-implicit-cast` warnings by adding explicit `static_cast<size_t>()` to one operand before integer multiplication to prevent overflow before widening. Also fix `clang-diagnostic-switch-enum` warnings by adding missing enum cases to switch statements, and various other minor lint fixes including NOLINT for `-inl.h` includes, `ShadowingClass` fix, and `BadImplicitCast` fix. Differential Revision: D100592783
junjieqi
force-pushed
the
export-D100592783
branch
from
e1366e3 to
2f6f691
Compare
…casts (#5092) Summary: Pull Request resolved: #5092 Fix 32 `facebook-avoid-non-const-global-variables` warnings by adding NOLINT comments to intentionally mutable global stats objects and configuration variables that are part of the public API (e.g., `indexIVF_stats`, `hnsw_stats`, `check_compatible_for_merge_expensive_check`). These cannot be made const as they accumulate runtime statistics and provide runtime configuration. Fix 25 `facebook-security-vulnerable-integer-implicit-cast` warnings by adding explicit `static_cast<size_t>()` to one operand before integer multiplication to prevent overflow before widening. Also fix `clang-diagnostic-switch-enum` warnings by adding missing enum cases to switch statements, and various other minor lint fixes including NOLINT for `-inl.h` includes, `ShadowingClass` fix, and `BadImplicitCast` fix. Differential Revision: D100592783
junjieqi
force-pushed
the
export-D100592783
branch
from
2f6f691 to
4a93ee9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix 32
facebook-avoid-non-const-global-variableswarnings by adding NOLINT comments to intentionally mutable global stats objects and configuration variables that are part of the public API (e.g.,indexIVF_stats,hnsw_stats,check_compatible_for_merge_expensive_check). These cannot be made const as they accumulate runtime statistics and provide runtime configuration.Fix 25
facebook-security-vulnerable-integer-implicit-castwarnings by adding explicitstatic_cast<size_t>()to one operand before integer multiplication to prevent overflow before widening. Also fixclang-diagnostic-switch-enumwarnings by adding missing enum cases to switch statements, and various other minor lint fixes including NOLINT for-inl.hincludes,ShadowingClassfix, andBadImplicitCastfix.Differential Revision: D100592783