Skip to content

Fix binary IVF reconstruct_n stride #5398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mmnhgo wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix binary IVF reconstruct_n stride #5398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion faiss/IndexBinaryIVF.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ void IndexBinaryIVF::reconstruct_n(idx_t i0, idx_t ni, uint8_t* recons) const {
continue;
}

uint8_t* reconstructed = recons + (id - i0) * d;
uint8_t* reconstructed = recons + (id - i0) * code_size;
reconstruct_from_offset(list_no, offset, reconstructed);
}
}
Expand Down
14 changes: 14 additions & 0 deletions tests/test_index_binary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,20 @@ def test_ivf_reconstruction(self):
self.xb[i]
)

def test_ivf_reconstruct_n_compact_output(self):
d = 64
code_size = d // 8
xb = np.arange(3 * code_size, dtype="uint8").reshape(3, code_size)

quantizer = faiss.IndexBinaryFlat(d)
quantizer.add(np.zeros((1, code_size), dtype="uint8"))

index = faiss.IndexBinaryIVF(quantizer, d, 1)
index.is_trained = True
index.add(xb)

np.testing.assert_array_equal(index.reconstruct_n(0, 3), xb)

def test_ivf_nprobe(self):
"""Test in case of nprobe > nlist."""
d = self.xq.shape[1] * 8
Expand Down