Reject AdditiveQuantizer with zero-bit code size on deserialization - #5506
Closed
juancarpio27 wants to merge 1 commit into
Closed
Reject AdditiveQuantizer with zero-bit code size on deserialization#5506juancarpio27 wants to merge 1 commit into
juancarpio27 wants to merge 1 commit into
Conversation
Summary: Deserializing an AdditiveQuantizer-based index (residual quantizer, local-search quantizer, and their product variants) validated that the number of sub-quantizers M is positive, but not that the resulting per-vector code size is nonzero. A crafted index can set every sub-quantizer's bit width to 0, which makes the derived code size 0 while the index still declares a positive vector count. Such an index ends up with an empty codes buffer whose data pointer is null/unspecified. Decoding any vector then dereferences that pointer inside the bitstring reader used to unpack per-vector codes, causing a segfault on fully attacker-controlled input. Reject this configuration right where the code size is derived, with a descriptive exception. A quantizer that stores zero bits per vector cannot decode anything and is never produced by real training, so this only rejects malformed/crafted inputs. Differential Revision: D115173394
Contributor
|
@juancarpio27 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115173394. |
Contributor
|
This pull request has been merged in a9ecee2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Deserializing an AdditiveQuantizer-based index (residual quantizer,
local-search quantizer, and their product variants) validated that the
number of sub-quantizers M is positive, but not that the resulting
per-vector code size is nonzero. A crafted index can set every
sub-quantizer's bit width to 0, which makes the derived code size 0
while the index still declares a positive vector count.
Such an index ends up with an empty codes buffer whose data pointer is
null/unspecified. Decoding any vector then dereferences that pointer
inside the bitstring reader used to unpack per-vector codes, causing a
segfault on fully attacker-controlled input.
Reject this configuration right where the code size is derived, with a
descriptive exception. A quantizer that stores zero bits per vector
cannot decode anything and is never produced by real training, so this
only rejects malformed/crafted inputs.
Differential Revision: D115173394