Skip to content

c_api: fix IndexReplicas own_indices getter/setter name mismatch - #5511

Open
Binozo wants to merge 1 commit into
facebookresearch:mainfrom
Binozo:fix/index-replicas-own-indices
Open

c_api: fix IndexReplicas own_indices getter/setter name mismatch#5511
Binozo wants to merge 1 commit into
facebookresearch:mainfrom
Binozo:fix/index-replicas-own-indices

Conversation

@Binozo

@Binozo Binozo commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

IndexReplicas_c.cpp defines:

DEFINE_GETTER(IndexReplicas, int, own_indices)
DEFINE_SETTER(IndexReplicas, int, own_indices)

while IndexReplicas_c.h defines

FAISS_DECLARE_GETTER_SETTER(IndexReplicas, int, own_fields)

this mismatch causes neither faiss_IndexReplicas_set_own_indices and faiss_IndexReplicas_set_own_fields to be exported in the c_api. This patch completes the migration to indices instead of fields in the c_api.

1 to 1 same problem/fix as in #5165

@meta-cla meta-cla Bot added the CLA Signed label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants