Skip to content

Vectorize RVV FP16 encoding with scalar-compatible rounding - #5603

Open
lyd1992 wants to merge 1 commit into
facebookresearch:mainfrom
lyd1992:rvv-sq-fp16-encode-20260907
Open

Vectorize RVV FP16 encoding with scalar-compatible rounding#5603
lyd1992 wants to merge 1 commit into
facebookresearch:mainfrom
lyd1992:rvv-sq-fp16-encode-20260907

Conversation

@lyd1992

@lyd1992 lyd1992 commented Sep 7, 2026

Copy link
Copy Markdown

RVV QT_fp16 currently inherits scalar encoding. This adds an RVV encoder while preserving the generic codec's byte representation, including its rounding behavior.

The generic codec uses ryg's scale-and-round conversion, whose halfway behavior differs from a direct IEEE round-to-nearest-even FP16 conversion. The vector path mirrors its mask, scale, clamp, bias, and sign operations. Chunks containing NaN or infinity use the scalar codec. The generic encoder becomes overridable so the RVV specialization can provide this implementation.

The new regression tests compare encoded bytes with the generic codec for finite values and, separately, for NaN/Inf inputs. Keeping these corpora separate exercises the vector path without allowing special-value fallback to hide an error. Tests include ties, subnormals, overflow boundaries, short tails, and output guards. This PR is independent of the other RVV encoding/distance changes.

Performance

Measured on a native SG2044 RISC-V host (VLEN=128), GCC 15.1, Release -O3, dynamic dispatch (FAISS_OPT_LEVEL=dd), rv64gcv_zvfhmin/lp64d, one thread pinned to CPU 2. The baseline is official commit 80a16564f86530dbf0bfaf96c2b71feffeb5093f; the candidate is that same baseline plus only this kernel change. These measurements were not collected on the newer PR base 2ed4c106e9fb9686e7727e5daf8ad6ad1e164109. The affected scalar-quantizer source files are unchanged between those bases, and the submitted kernel differs from the measured one only in comments/formatting.

Public path Dimension Baseline ns/element Candidate ns/element Paired speedup 95% interval
FP16 encode 16 4.714 2.283 2.014x [1.966, 2.089]
FP16 encode 32 4.151 1.776 2.302x [1.802, 2.346]
FP16 encode 128 3.929 1.450 2.697x [1.998, 2.712]
FP16 encode 768 3.620 1.556 2.322x [2.272, 2.380]

Geometric mean of the dimension-specific speedups at d=32/128/768: FP16 encode 2.434x.

There are three consecutive sessions, each with four alternating ABBA/BAAB blocks per dimension/path: 48 paired blocks for this candidate. A is the baseline and B is the candidate. Each call is calibrated to at least 0.1 s (the shortest formal call in the full campaign was 0.192 s), with three warm-up batches and n = max(32, floor(32768/d)). Each block uses the ratio of the two-call geometric mean times. Reported speedup is the median of the three session medians; intervals use 5,000 hierarchical bootstrap resamples, resampling sessions and then blocks within each ABBA/BAAB order stratum. The timing columns are separate medians, so their quotient need not equal the paired speedup. All 48 paired blocks favored this candidate.

The timed operation is public ScalarQuantizer::compute_codes, using fixed-seed (718) finite input batches. FP16 input values are float(int(rng()%100000)-50000)/113.f.

Variability is material at d=32/128: paired-ratio CV is 13.25%/13.47%, and ABBA-vs-BAAB order gaps are 13.46%/4.80%. The d=32/128/768 geometric mean for the individual sessions is 2.419x, 2.040x, and 2.463x. The aggregate 2.434x should therefore not be interpreted as a stable per-run guarantee.

These results describe public encoding/distance throughput on one non-exclusive host, not end-to-end ANN search speedup. The intervals describe these sessions only, with no multiple-comparison correction; they do not establish portability across machines or vector lengths.

Validation

  • Native public encoding oracle: 11,564,775 input elements across the five RISC-V rounding modes; zero differing output bytes or write-guard failures. The corpus covers FP16 values and neighboring floats, ties, subnormals, overflow, signed zeros, and NaN payloads. FP exception flags were recorded, not asserted equivalent.
  • Original benchmark baseline full C++ suite: 273 passed, 7 skipped, 0 failed.
  • Submission version on 2ed4c106e9fb9686e7727e5daf8ad6ad1e164109: all three independent candidate builds succeeded; this PR's focused C++ suite (NONE: 11 passed, 6 skipped, 0 failed; RISCV_RVV: 13 passed, 4 skipped, 0 failed) and the public-path oracle above pass on native RISC-V. The newly added RVV regression tests are executed and passed in the RVV run, and skipped when RVV is disabled in the NONE run.
  • All touched C++ files pass clang-format 21.1.8; git diff --check clean.

Co-authored-by: ww8191201-coder <wanghongyan2025@iscas.ac.cn>
Co-authored-by: ihb2032 <hebome@foxmail.com>
Co-authored-by: YuanSheng <yuansheng@isrc.iscas.ac.cn>
@meta-cla

meta-cla Bot commented Sep 7, 2026

Copy link
Copy Markdown

Hi @lyd1992!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Sep 7, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Sep 7, 2026
@meta-cla

meta-cla Bot commented Sep 7, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant