Fix python binding compilation for Windows#1352
Fix python binding compilation for Windows#1352fstp wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
When building using MSVC the CL compiler will fail with the following error: fasttext_pybind.cc(171): error C2065: 'ssize_t': undeclared identifier It seems like ssize_t is a non-standard posix extension which is not defined in Windows, I added a typedef to the windows version SSIZE_T to fix it.
|
Hi @fstp! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@r-barnes |
2 participants
When building using MSVC the CL compiler will
fail with the following error:
fasttext_pybind.cc(171): error C2065: 'ssize_t': undeclared identifier
It seems like ssize_t is a non-standard posix extension which is not defined in Windows, I added a typedef to the windows version SSIZE_T to fix it.