Skip to content

T138861426: [Bootcamp][PCF][BE] Migrate the DotproductGame to use the new API that accepts metric collector. #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slaxman1978 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

T138861426: [Bootcamp][PCF][BE] Migrate the DotproductGame to use the new API that accepts metric collector. #453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions fbpcf/mpc_std_lib/walr_multiplication/OTBasedMatrixMultiplicationFactory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ class OTBasedMatrixMultiplicationFactory final
public:
const std::string metricRecorderNamePrefix = "ot_based_matrix_multiplication";

// The following constructor will be deprecated once we updated all APP codes
explicit OTBasedMatrixMultiplicationFactory(
[[deprecated("Use the constructor with MetricCollector instead.")]] explicit OTBasedMatrixMultiplicationFactory(
int myId,
int partnerId,
bool isFeatureOwner,
Expand Down