Fix data schema in example evaluation script#21
Merged
antoine-tran merged 17 commits intomainfrom Jan 16, 2025
Merged
Conversation
added 16 commits
January 14, 2025 14:40
Contributor
Author
|
Merged despite the CI failures to fix the issues |
LUIGIVAMPER
pushed a commit
to XiangningLin/large_concept_model
that referenced
this pull request
Nov 25, 2025
Fix data schema in example evaluation script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why ?
In example evaluation script ("examples/evaluation/prepare_evaluation_data.py"), the processed datasets are hardcoded with the column schema with new names "prompt", "answer". This was done to make the next data processing steps in LCM evaluation (sentence splitting, sonar embedding) easier, but it was inconsistent in LLM evaluation, because they do not need much data processing and can work directly with original dataset.
This PR makes the following changes to make the evaluation script more flexible:
prompt_prefix,prompt_suffix), we rename the columns to "prompt" and "answer".NOTE: There is an issue in Python 3.12 compatibility related to stopes facebookresearch/stopes#71 , which also makes the current CI failed. This PR was tested and passed on Python 3.11