This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Fixing IndexError on grouped_batch_sampler.py#656
Open
LeviViana wants to merge 11 commits intofacebookresearch:mainfrom
Open
Fixing IndexError on grouped_batch_sampler.py#656LeviViana wants to merge 11 commits intofacebookresearch:mainfrom
LeviViana wants to merge 11 commits intofacebookresearch:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
fmassa
suggested changes
May 29, 2019
Contributor
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
I'm not sure this is the right fix, even though it might look like it avoids having the error.
I think the best solution here is to use the sampler from torchvision, which I believe handles all those cases properly
Contributor
|
Hey @LeviViana, Thanks for your fix. |
Contributor
Author
|
@botcs, I guess this is it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #474 and #55.