Merged
Conversation
meta-cla
bot
added
the
CLA Signed
yangli5t
reviewed
Aug 29, 2025
yangli5t
reviewed
Aug 29, 2025
yangli5t
reviewed
Aug 29, 2025
Comment on lines
+145
to
+150
| session_timeout = aiohttp.ClientTimeout(total=timeout + 5) if timeout else None | ||
| async with aiohttp.ClientSession(timeout=session_timeout) as session: | ||
| status, content = await post_url( | ||
| session, f"{self.base_url}/execute", payload | ||
| ) | ||
| return await self._handle_response(status, content) |
Contributor
There was a problem hiding this comment.
consider make util function? seems several occurance and only different in timeout and url?
yangli5t
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why ?
Fix seveal container issues during testing swe-bench
How ?
Test plan
matrix check_health --app_name container