Skip to content

Fix parameter name in README: replace --hf_split with --hf-split - #15

Open
dafu-wu wants to merge 1 commit into
facebookresearch:mainfrom
dafu-wu:main
Open

Fix parameter name in README: replace --hf_split with --hf-split#15
dafu-wu wants to merge 1 commit into
facebookresearch:mainfrom
dafu-wu:main

Conversation

@dafu-wu

@dafu-wu dafu-wu commented Oct 19, 2025

Copy link
Copy Markdown

📋 Summary

🎯 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes, no api changes)
  • ⚡ Performance improvement
  • 🧪 Test addition or improvement
  • 🔨 Build/CI changes

🏗️ Meta Agents Research Environments Components Affected

  • Environment (are/simulation/environment.py, are/simulation/core/, environment setup/configuration)
  • UI/GUI (are/simulation/gui/, web interface, client-side components)
  • Scenarios (are/simulation/scenarios/, scenario definitions, scenario runner)
  • Agents (are/simulation/agents/, agent implementations)
  • Documentation (README, docs, comments)
  • Build/CI (GitHub Actions, Docker, dependencies)

🔗 Related Issues

🧪 Testing Strategy

  • Unit Tests: Added/updated unit tests
  • Integration Tests: Tested integration with other components
  • Manual Testing: Manually verified functionality
  • Scenario Testing: Ran specific scenarios to validate changes
  • GUI Testing: Tested web interface (if applicable)
  • Regression Testing: Verified existing functionality still works

Test Details

🤖 AI Usage Declaration

📸 Screenshots/Recordings

⚠️ Breaking Changes

📋 Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

@meta-cla

meta-cla Bot commented Oct 19, 2025

Copy link
Copy Markdown

Hi @dafu-wu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Oct 19, 2025

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the cla signed label Oct 19, 2025

@mlecanu mlecanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants