Delete deletion-eligible ALBEF test_vision_transformer - #552
Closed
twmoveon wants to merge 2 commits into
Closed
Conversation
…#551) Summary: Oncall test cleanup for the `stl_multimodal` rotation. TestX flags these four tests in `tests/models/albef/test_albef.py` as eligible for deletion — all sit in `DISABLED_FAILING` trunk state with open `FAILURE` issues, well past the 60-day zero-value threshold: - `test_albef_image_embeddings` (`844425197297248`, `844425197101365`) - `test_albef_image_embeddings_momentum` (`562950220612232`, `844425197101313`) - `test_albef_multimodal_embeddings` (`844425197297177`, `844425197101408`) - `test_albef_multimodal_embeddings_momentum` (`562950220612287`, `281475243658978`) Each asserted a hard-coded 2x2x3 activation tensor to `atol=1e-4` against a seeded forward pass — golden values that drift whenever RNG or kernel behavior changes underneath them. Re-baselining numbers nobody has validated since they broke would restore a green signal without restoring any real assurance, so they are deleted instead. The `albef_model_output` fixture and the surrounding tests are untouched: `test_albef_text_embeddings` and `test_albef_text_embeddings_momentum` still exercise the same forward pass, and `test_similarity`, `test_neg_embeddings`, `test_dequeue_and_enqueue`, `test_momentum_update`, and `test_copy_params_momentum_models` still cover `ALBEFModelWithSimilarity`. Differential Revision: D114397069
Summary: Oncall test cleanup for the `stl_multimodal` rotation. TestX flags `TestALBEFVisionEncoder.test_vision_transformer` (test IDs `281475243855620` and `281475243658858`) as eligible for deletion — it sits in `DISABLED_FAILING` trunk state with an open `FAILURE` issue, well past the 60-day zero-value threshold. It was another seeded golden-value test, asserting a hard-coded 1x2x3 tensor to `atol=1e-4`, so it is deleted rather than re-baselined. `assert_expected` and `Tensor` were only used by the deleted test, so both imports are dropped. `set_rng_seed` stays — it is still called at class scope. The four negative tests remain and are the more durable half of this file: `test_invalid_input_length`, `test_invalid_image_channel_dim`, `test_invalid_image_height`, and `test_invalid_image_width` still pin `ALBEFVisionEncoder` input validation. Differential Revision: D114397059
meta-cla
Bot
added
the
CLA Signed
|
@twmoveon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114397059. |
|
This pull request has been merged in 1effea7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Oncall test cleanup for the
stl_multimodalrotation. TestX flagsTestALBEFVisionEncoder.test_vision_transformer(test IDs281475243855620and
281475243658858) as eligible for deletion — it sits inDISABLED_FAILINGtrunk state with an openFAILUREissue, well past the60-day zero-value threshold.
It was another seeded golden-value test, asserting a hard-coded 1x2x3 tensor to
atol=1e-4, so it is deleted rather than re-baselined.assert_expectedandTensorwere only used by the deleted test, so bothimports are dropped.
set_rng_seedstays — it is still called at class scope.The four negative tests remain and are the more durable half of this file:
test_invalid_input_length,test_invalid_image_channel_dim,test_invalid_image_height, andtest_invalid_image_widthstill pinALBEFVisionEncoderinput validation.Differential Revision: D114397059