enable pseudo-inverse behavior in eigendecomposition-based amortized computation #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72204068 |
anana10c
added a commit
to anana10c/optimizers
that referenced
this pull request
Apr 1, 2025
…computation (facebookresearch#120) Summary: Port changes from D71908578 to OSS Shampoo. Differential Revision: D72204068
anana10c
force-pushed
the
export-D72204068
branch
from
27f7106 to
f34500f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72204068 |
…computation (facebookresearch#120) Summary: Port changes from D71908578 to OSS Shampoo. Differential Revision: D72204068
anana10c
force-pushed
the
export-D72204068
branch
from
f34500f to
ac951a0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72204068 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable pseudo-inverse behavior in eigendecomposition-based computation with a unique config
PseudoInverseConfiginheriting fromNonInvertibleHandlingConfig. (Pseudo-inverse implementation adapted from #11.) Refactorenhance_stabilityflag as an argument forRegularizationConfig, anotherNonInvertibleHandlingConfigthat perturbs the matrix with a given epsilon, i.e. the default behavior.Note that the inverse root/exponent computation has been refactored out into
scale_and_pow_eigenvalues(), which fixes a bug introduced inEigendecomposedShampooPreconditionerListwhere the eigenvalues were not being adjusted by the minimum eigenvalue (if it was negative) before being scaled by epsilon.In the future, we intend to generalize the pseudo-inverse to all amortized computation methods, so
noninvertible_handling_configshould eventually be moved underMatrixFunctionConfig.Changes ported from D71908578 (internal) to OSS Shampoo.