Update common utility function : distribute_buffer_sizes #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Same logics were implemented for distributed_buffer_sizes, and it is uniformed - Files : shampoo_hsdp_distributor.py, shampoo_ddp_distributor.py, shampoo_hybrid_shard_distributor.py - It is moved to shampoo_utils.py for common function. - Update shampoo_utils_test.py for testing distribute_buffer_sizes
facebook-github-bot
added
the
CLA Signed
1 task
tsunghsienlee
approved these changes
Mar 25, 2025
|
@tsunghsienlee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tsunghsienlee
requested changes
Mar 25, 2025
Yes that would be dead code. I will fix it. |
- It is uniformed and moved into utils/shampoo_utils.py
tsunghsienlee
approved these changes
Mar 25, 2025
|
@tsunghsienlee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tsunghsienlee merged this pull request in a09c04b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the rebased PR for #94 (already approved)