Fix CQS signal modernize-use-integer-sign-comparison in arvr/projects/ariane/aria_research_kit [B] (#369)

Summary: Pull Request resolved: #369

Reviewed By: PiotrBrzyski

Differential Revision: D111914421

fbshipit-source-id: f75e65907fda2cfc6455a9ab3c3e968cb1f09ffa

Author: generatedunixname1587093422349604

core/image/ImageIterator.h

@@ -17,6 +17,7 @@
 #pragma once
 
 #include <iterator>
+#include <utility>
 
 #include "Portability.h"
 
@@ -139,7 +140,7 @@ class ImageIterator {
   }
   PROJECTARIA_HOST_DEVICE_INLINE void stepForward(const difference_type delta) {
     const size_t remainingInRow = std::distance(ptr, rowEnd);
-    if (remainingInRow <= delta) {
+    if (std::cmp_less_equal(remainingInRow, delta)) {
       const size_t w = width();
       const size_t numRows = 1 + (delta - remainingInRow) / w;
       const size_t rowPosition = (delta - remainingInRow) % w;
@@ -152,7 +153,7 @@ class ImageIterator {
   }
   PROJECTARIA_HOST_DEVICE_INLINE void stepBackward(const difference_type delta) {
     const size_t remainingInRow = ptr - rowStart;
-    if (remainingInRow < delta) {
+    if (std::cmp_less(remainingInRow, delta)) {
       const size_t w = width();
       const size_t numRows = 1 + (delta - remainingInRow - 1) / w;
       const size_t rowPosition = 1 + (delta - remainingInRow - 1) % w;

examples/Gen1/cpp_samples/pointcloud_colorization/RGBPointCloudColorizer.h

@@ -22,6 +22,7 @@
 
 #include <boost/timer/progress_display.hpp>
 #include <unordered_map>
+#include <utility>
 
 namespace {
 
@@ -86,7 +87,7 @@ class RGBPointCloudColorizer : public PointCloudColorizer {
     {
       boost::timer::progress_display progressBar(
           numRgbData, std::cout, "Looping over VRS image frames and PointCloud observations.\n");
-      for (int64_t frameId = 0; frameId < numRgbData; ++frameId) {
+      for (int64_t frameId = 0; std::cmp_less(frameId, numRgbData); ++frameId) {
         ++progressBar;
 
         //

examples/Gen1/cpp_samples/pointcloud_colorization/SLAMPointCloudColorizer.h

@@ -22,6 +22,7 @@
 
 #include <boost/timer/progress_display.hpp>
 #include <unordered_map>
+#include <utility>
 
 namespace {
 // Colorize a GlobalPointCloud given its SLAM image observations.
@@ -89,7 +90,7 @@ class SLAMPointCloudColorizer : public PointCloudColorizer {
     {
       boost::timer::progress_display progressBar(
           numSlamData, std::cout, "Looping over VRS image frames and PointCloud observations.\n");
-      for (int64_t frameId = 0; frameId < numSlamData; ++frameId) {
+      for (int64_t frameId = 0; std::cmp_less(frameId, numSlamData); ++frameId) {
         ++progressBar;
 
         //

tools/visualization/AriaPlayer.cpp

@@ -18,6 +18,8 @@
 
 #ifdef BUILD_INTERNAL_PROJECTARIA_TOOLS
 #include <data_provider/internal/VrsDataProvider.h>
+
+#include <utility>
 #endif
 
 using namespace projectaria::tools::data_provider;
@@ -82,7 +84,7 @@ void AriaPlayer::playStreamFromTimeNs(int64_t timestampNs, const vrs::StreamId&
 
   int64_t playbackStartTime = timestampNs;
   auto systemStartTime = std::chrono::steady_clock::now();
-  for (size_t i = startIndex; i < numData; ++i) {
+  for (size_t i = startIndex; std::cmp_less(i, numData); ++i) {
     if (!visControl_->isPlaying_ || visControl_->shouldClose_) {
       return;
     }

tools/visualization/AriaVisualizationControlAndData.cpp

@@ -19,6 +19,7 @@
 #include "vrs/StreamId.h"
 
 #include <chrono>
+#include <utility>
 
 void AriaVisualizationData::initDataStreams(
     const std::vector<vrs::StreamId>& kImageStreamIds,
@@ -96,8 +97,8 @@ bool AriaVisualizationData::updateData(
       }
 
       // Audio samples are 32bit; convert to float for visualization
-      for (size_t i = 0; i < audioMatrix.rows(); ++i) {
-        for (size_t c = 0; c < audioMatrix.cols(); ++c) {
+      for (size_t i = 0; std::cmp_less(i, audioMatrix.rows()); ++i) {
+        for (size_t c = 0; std::cmp_less(c, audioMatrix.cols()); ++c) {
           audio_[i][c] = static_cast<float>(audioMatrix(i, c) / maxAmplitude);
         }
       }