{Feature} Core - Add random-access P-frame decoding support in ImageSensorPlayer#339
Open
kongchen1992 wants to merge 1 commit intofacebookresearch:mainfrom
Open
{Feature} Core - Add random-access P-frame decoding support in ImageSensorPlayer#339kongchen1992 wants to merge 1 commit intofacebookresearch:mainfrom
kongchen1992 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
…ensorPlayer Summary: Adds random-access support for P-frame video streams in VrsDataProvider. Previously, getImageDataByIndex() only worked correctly for sequential reads or I-frames. Reading a mid-GOP P-frame out of order returned incorrect pixels because the decoder's DPB (Decoded Picture Buffer) lacked the required reference frames. This adds a recordReadComplete() override in ImageSensorPlayer that detects isMissingFrames() and walks back to the preceding keyframe via readMissingFrames(), then replays through the target frame. The user callback fires exactly once per getImageDataByIndex() call, even when the replay decodes multiple intermediate frames. Enables random-access video frame retrieval for training data pipelines, video editors, and any workflow that needs non-sequential frame access. Differential Revision: D101928539
Contributor
|
@kongchen1992 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101928539. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds random-access support for P-frame video streams in VrsDataProvider.
Previously, getImageDataByIndex() only worked correctly for sequential reads or I-frames. Reading a mid-GOP P-frame out of order returned incorrect pixels because the decoder's DPB (Decoded Picture Buffer) lacked the required reference frames.
This adds a recordReadComplete() override in ImageSensorPlayer that detects isMissingFrames() and walks back to the preceding keyframe via readMissingFrames(), then replays through the target frame. The user callback fires exactly once per getImageDataByIndex() call, even when the replay decodes multiple intermediate frames.
Enables random-access video frame retrieval for training data pipelines, video editors, and any workflow that needs non-sequential frame access.
Differential Revision: D101928539