{Continuous Integration} Test Wheel Build - Update cibuildwheel to 2.21.0 and drop EOL Python versions - #349
Closed
robertl0 wants to merge 1 commit into
Closed
Conversation
…21.0 and drop EOL Python versions Summary: Explanation: Sets up the test wheel build workflow as a release-readiness canary. A follow-up diff will add a weekly schedule trigger so this workflow runs automatically each Monday — the goal is to detect cibuildwheel/delocate/runner-image drift before it blocks a release. For that signal to be useful, this diff first updates the workflow to a forward-compatible cibuildwheel + delocate environment; without this preparation, scheduling the existing pinned 2-year-old environment would re-run the same frozen build every Monday and detect no drift. Brings cibuildwheel from 2.17.0 (pinned in 2024 due to a macOS dylib delocation issue) to 2.21.0, and sets MACOSX_DEPLOYMENT_TARGET=14.0 to satisfy the strict wheel-tag check in delocate 0.12.0 (a transitive dependency that newer cibuildwheel pulls). Drops Python 3.8 and 3.9 matrix entries -- they are EOL and no longer supported by GitHub runner images. This is the same recipe applied to projectaria_private_libs. Note: this changes the macOS install floor for wheels built by this canary to macOS 14 (Sonoma) and later. macOS 11/12/13 are no longer testable on GitHub Actions (macos-13 runners deprecated late 2025), so this matches the testable surface. Reproducibility: Triggered the workflow manually via workflow_dispatch after the change; all 6 matrix cells (macos-14 + ubuntu-latest x Python 3.10/3.11/3.12) built and tested wheels successfully. Inspected wheel filenames to confirm the manylinux tag did not shift unexpectedly. Differential Revision: D104881993
Contributor
|
@robertl0 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104881993. |
Contributor
|
This pull request has been merged in fdb747e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Explanation:
Sets up the test wheel build workflow as a release-readiness canary. A follow-up diff will add a weekly schedule trigger so this workflow runs automatically each Monday — the goal is to detect cibuildwheel/delocate/runner-image drift before it blocks a release. For that signal to be useful, this diff first updates the workflow to a forward-compatible cibuildwheel + delocate environment; without this preparation, scheduling the existing pinned 2-year-old environment would re-run the same frozen build every Monday and detect no drift.
Brings cibuildwheel from 2.17.0 (pinned in 2024 due to a macOS dylib delocation issue) to 2.21.0, and sets MACOSX_DEPLOYMENT_TARGET=14.0 to satisfy the strict wheel-tag check in delocate 0.12.0 (a transitive dependency that newer cibuildwheel pulls). Drops Python 3.8 and 3.9 matrix entries -- they are EOL and no longer supported by GitHub runner images. This is the same recipe applied to projectaria_private_libs.
Note: this changes the macOS install floor for wheels built by this canary to macOS 14 (Sonoma) and later. macOS 11/12/13 are no longer testable on GitHub Actions (macos-13 runners deprecated late 2025), so this matches the testable surface.
Reproducibility:
Triggered the workflow manually via workflow_dispatch after the change; all 6 matrix cells (macos-14 + ubuntu-latest x Python 3.10/3.11/3.12) built and tested wheels successfully. Inspected wheel filenames to confirm the manylinux tag did not shift unexpectedly.
Differential Revision: D104881993