{Continuous Integration} Test Wheel Build - Restore Python 3.9 ubuntu matrix entry to mirror publish workflow (#350) - #350
Closed
robertl0 wants to merge 1 commit into
Closed
Conversation
Contributor
|
@robertl0 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104899027. |
… matrix entry to mirror publish workflow (facebookresearch#350) Summary: Explanation: The previous canary recipe diff dropped Python 3.9 from the test-for-build-wheels matrix, but the publish workflow (build-wheels-and-deploy.yml) still ships a cp39 Linux wheel on every release. Without 3.9 in the canary, a future cibuildwheel/runner-image change that breaks 3.9 wheel builds would only be detected on release day. Restores the Python 3.9 ubuntu-latest entry so the canary matrix mirrors the publish matrix exactly: macOS 14 x {3.10, 3.11, 3.12} + ubuntu-latest x {3.9, 3.10, 3.11, 3.12} = 7 cells. Reproducibility: N/A -- matrix-only change. The 3.9 wheel will build with the existing CIBW_BUILD: cp39-* pattern that was previously in this file. Differential Revision: D104899027
meta-codesync
Bot
changed the title
robertl0
force-pushed
the
export-D104899027
branch
from
May 12, 2026 22:43
8f44ed2 to
5f9c81b
Compare
Contributor
|
This pull request has been merged in 6fa65d3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Explanation:
The previous canary recipe diff dropped Python 3.9 from the test-for-build-wheels matrix, but the publish workflow (build-wheels-and-deploy.yml) still ships a cp39 Linux wheel on every release. Without 3.9 in the canary, a future cibuildwheel/runner-image change that breaks 3.9 wheel builds would only be detected on release day.
Restores the Python 3.9 ubuntu-latest entry so the canary matrix mirrors the publish matrix exactly: macOS 14 x {3.10, 3.11, 3.12} + ubuntu-latest x {3.9, 3.10, 3.11, 3.12} = 7 cells.
Reproducibility:
N/A -- matrix-only change. The 3.9 wheel will build with the existing CIBW_BUILD: cp39-* pattern that was previously in this file.
Differential Revision: D104899027