Fix: Migrate pkg_resources to import lib.resources for Python 3.9+ compatibility - #537
Fix: Migrate pkg_resources to import lib.resources for Python 3.9+ compatibility#537RahmaniSajjad wants to merge 1 commit into
Conversation
Migrate asset resolution in sam3/model_builder.py to use importlib.resources. This fixes compatibility issues with setuptools >= 82.0.0, where pkg_resources.resource_filename() was removed. No functional changes introduced.
|
Hi @RahmaniSajjad! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
This PR replaces the deprecated
pkg_resources.resource_filename()withimportlib.resources.files()insam3/model_builder.py. This migration is necessary to supportsetuptools >= 82.0.0, which removed thepkg_resourcesAPI.Changes
import pkg_resources.from importlib.resources import files.importlibfor asset path resolution:build_sam3_image_modelbuild_sam3_video_modelbuild_sam3_multiplex_video_predictorTraversableobjects tostrto ensure backward compatibility withSimpleTokenizer.Context
The previous implementation relied on an API that is no longer available in the latest
setuptoolsreleases, causing installation and runtime failures in modern Python environments. Usingimportlib.resources(available since Python 3.9) provides a stable, built-in solution and removes the runtime dependency onsetuptoolsfor asset resolution.Related Issues
Fixes #462