Security: Command injection via shell=True in subprocess.run

[tuanaiseo]

Problem

The run_command function in scripts/eval/silver/utils.py uses subprocess.run(cmd, shell=True) where cmd is passed directly. While the current callers may not be directly user-facing, this pattern is dangerous as any caller could pass unsanitized input leading to shell command injection.

Severity: high
File: scripts/eval/silver/utils.py

Solution

Avoid shell=True and pass commands as lists of arguments. If shell features are needed, use shlex.quote() to sanitize inputs. Change to subprocess.run(cmd, shell=False) with proper argument splitting.

Changes

• scripts/eval/silver/utils.py (modified)

Testing

• Existing tests pass
• Manual review completed
• No new warnings/errors introduced

[meta-cla]

Hi @tuanaiseo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!