Skip to content

Add einops to base dependencies (fixes #212) - #589

Open
jkukul wants to merge 1 commit into
facebookresearch:mainfrom
jkukul:fix/einops-base-dependency
Open

Add einops to base dependencies (fixes #212)#589
jkukul wants to merge 1 commit into
facebookresearch:mainfrom
jkukul:fix/einops-base-dependency

Conversation

@jkukul

@jkukul jkukul commented Jun 19, 2026

Copy link
Copy Markdown

Summary

einops is imported at module-load time on the core model path but is only declared in
the optional notebooks extra, so a base install (pip install . or
pip install git+https://github.com/facebookresearch/sam3.git) crashes on import sam3.

This moves einops into [project].dependencies so the package imports out of the box.

Fixes #212.

The import chain that triggers it

import sam3sam3/__init__.pymodel_buildermodel/decoder
sam/transformersam/rope.py, which does:

from einops import rearrange, repeat

This is on the default inference path (RoPE), not behind any use_fa3 / notebook / fast-kernel guard, so every consumer needs einops.

@meta-cla

meta-cla Bot commented Jun 19, 2026

Copy link
Copy Markdown

Hi @jkukul!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 19, 2026
@meta-cla

meta-cla Bot commented Jun 19, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'einops'

1 participant