Add einops to base dependencies (fixes #212) - #589
Conversation
|
Hi @jkukul! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
einopsis imported at module-load time on the core model path but is only declared inthe optional
notebooksextra, so a base install (pip install .orpip install git+https://github.com/facebookresearch/sam3.git) crashes onimport sam3.This moves
einopsinto[project].dependenciesso the package imports out of the box.Fixes #212.
The import chain that triggers it
import sam3→sam3/__init__.py→model_builder→model/decoder→sam/transformer→sam/rope.py, which does:This is on the default inference path (RoPE), not behind any use_fa3 / notebook / fast-kernel guard, so every consumer needs
einops.