Conversation
Internalize the weakref-based auto-shutdown pattern into Pipeline itself, so users no longer need to manually call `start()` / `stop()` or use `auto_stop()`. The current `Pipeline` class is renamed to `_PipelineImpl` (internal). A new public `Pipeline` facade wraps it and: - Registers a `weakref.finalize` callback that cleanly calls `impl.stop()` when the facade is garbage collected, replacing the old emergency-warning finalizer as the primary cleanup mechanism. - Auto-starts the background thread on first `get_item()` call if the user has not explicitly called `start()`. - Preserves the existing explicit `start()` / `stop()` / `auto_stop()` API unchanged — calling `start()` twice still raises `RuntimeError`, calling `stop()` multiple times is still safe. The `_PipelineImpl` retains its own `_ensure_stopped` emergency finalizer as a safety net. Other changes: - `_build_pipeline()` (private) returns `_PipelineImpl`; `build_pipeline()` (public) wraps in facade. - `_ProfilePipeline` subclasses `_PipelineImpl`; diagnostic mode wraps in facade. - Profiling code uses the public `Pipeline` API.
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D102223323. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the changes #1373 and #1375, we no longer need to explicitly start pipeline.
This allows to simply do
for item in pipeline:.Simplifies the example as such