{Build} Add CMake support for OPUS build#172
Closed
SeaOtocinclus wants to merge 3 commits intofacebookresearch:mainfrom
Closed
{Build} Add CMake support for OPUS build#172SeaOtocinclus wants to merge 3 commits intofacebookresearch:mainfrom
SeaOtocinclus wants to merge 3 commits intofacebookresearch:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68632323 |
Summary: Include OPUS as a pure C library since it is a C library Differential Revision: D72646388
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68632323 |
SeaOtocinclus
added a commit
to SeaOtocinclus/vrs
that referenced
this pull request
Apr 8, 2025
Summary: Pull Request resolved: facebookresearch#172 Auto-detect Opus if installed - Configure a CMake preprocessor `BUILD_WITH_OPUS` accordingly - If opus detected: - link Opus::opus to the target - add compilation preprocessor`OPUS_IS_AVAILABLE` CPP Differential Revision: D68632323
SeaOtocinclus
force-pushed
the
export-D68632323
branch
from
cae2b1b to
16da108
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68632323 |
SeaOtocinclus
force-pushed
the
export-D68632323
branch
from
16da108 to
f76de1a
Compare
SeaOtocinclus
added a commit
to SeaOtocinclus/vrs
that referenced
this pull request
Apr 8, 2025
Summary: Pull Request resolved: facebookresearch#172 Auto-detect Opus if installed - Configure a CMake preprocessor `BUILD_WITH_OPUS` accordingly - If opus detected: - link Opus::opus to the target - add compilation preprocessor`OPUS_IS_AVAILABLE` CPP Differential Revision: D68632323
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68632323 |
SeaOtocinclus
force-pushed
the
export-D68632323
branch
from
f76de1a to
2b88f3f
Compare
SeaOtocinclus
added a commit
to SeaOtocinclus/vrs
that referenced
this pull request
Apr 8, 2025
Summary: Pull Request resolved: facebookresearch#172 Auto-detect Opus if installed - Configure a CMake preprocessor `BUILD_WITH_OPUS` accordingly - If opus detected: - link Opus::opus to the target - add compilation preprocessor`OPUS_IS_AVAILABLE` CPP Differential Revision: D68632323
Summary: As we are running update and install libraries later, we don't need to run upgrade. Differential Revision: D72653490
SeaOtocinclus
added a commit
to SeaOtocinclus/vrs
that referenced
this pull request
Apr 8, 2025
Summary: Auto-detect Opus if installed - Configure a CMake preprocessor `BUILD_WITH_OPUS` accordingly - If opus detected: - link Opus::opus to the target - add compilation preprocessor`OPUS_IS_AVAILABLE` CPP Differential Revision: D68632323
SeaOtocinclus
force-pushed
the
export-D68632323
branch
from
2b88f3f to
8498a62
Compare
Summary: Pull Request resolved: facebookresearch#172 Auto-detect Opus if installed - Configure a CMake preprocessor `BUILD_WITH_OPUS` accordingly - If opus detected: - link Opus::opus to the target - add compilation preprocessor`OPUS_IS_AVAILABLE` CPP Differential Revision: D68632323
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68632323 |
SeaOtocinclus
force-pushed
the
export-D68632323
branch
from
8498a62 to
184d69b
Compare
SeaOtocinclus
added a commit
to SeaOtocinclus/vrs
that referenced
this pull request
Apr 9, 2025
Summary: Pull Request resolved: facebookresearch#172 Auto-detect Opus if installed - Configure a CMake preprocessor `BUILD_WITH_OPUS` accordingly - If opus detected: - link Opus::opus to the target - add compilation preprocessor`OPUS_IS_AVAILABLE` CPP Differential Revision: D68632323 Privacy Context Container: L1163201
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Enable optional OPUS compilation
BUILD_WITH_OPUSOPUS_IS_AVAILABLECPPpixi run buildto compile with OPUS support by default to ease CI and testing long term support of the featureDifferential Revision:
D68632323
Privacy Context Container: L1163201