Make the installed CMake package reusable - #263
Open
jeongseok-meta wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The installed CMake package currently cannot be consumed reliably: exported targets are imported before their dependency targets exist, Ocean is fetched and rebuilt in the downstream project, and a required public include file is omitted from the install. Package managers also need a supported way to use a maintained system RapidJSON package without replacing the upstream finder.
This generalizes the workaround currently carried by conda-forge:
https://github.com/conda-forge/vrs-feedstock/blob/main/recipe/patches/0001-use-conda-deps-in-cmake-config.patch
Related to #147.
Test plan
CI note
The Pixi environment uses the maintained RapidJSON post20240409 snapshot and retains libcxx 16 on macOS to match the existing cxx-compiler 1.6 clang-16 toolchain. An unconstrained RapidJSON solve upgraded libcxx to 22, which is not compatible with that pinned compiler.